Thread (2 messages) read the whole thread 2 messages, 2 authors, 2026-03-05

Re: [PATCH net v5 4/9] ice: change XDP RxQ frag_size from DMA write length to xdp.frame_sz

From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: 2026-03-05 15:18:37
Also in: bpf, imx, intel-wired-lan, linux-kselftest, lkml

Hi Frank,

On Thu, Mar 05, 2026 at 10:08:56AM -0500, Frank Li wrote:
From: Frank Li (AI-BOT) <frank.li@nxp.com>
quoted
		if (ring->xsk_pool) {
-			rx_buf_len =
-				xsk_pool_get_rx_frame_size(ring->xsk_pool);
+			u32 frag_size =
+				xsk_pool_get_rx_frag_step(ring->xsk_pool);
AI: Variable declaration should be at the start of the block, not inline.
Move `u32 frag_size;` to the top with other declarations.

Although it allow declear varible at any place now, still perfer AI's
suggest here.

Frank
A "block" or a "compound statement" in C is the piece of code encircled
by { and }. We _do_ have them, so the "u32 frag_size" variable _is_
declared at the start of that block, as a matter of fact. There is
nothing wrong here, the variable placement is not arbitrary.

Which AI tool signalled this?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help