Re: [PATCH net-next 1/2] dt-bindings: net: Add support for Airoha AN8801/R GbE PHY
From: Louis-Alexis Eyraud <hidden>
Date: 2026-03-05 09:00:42
Also in:
linux-arm-kernel, linux-devicetree, linux-mediatek, lkml
Hi Maxime, On Wed, 2026-03-04 at 11:14 +0100, Maxime Chevallier wrote:
Hi Louis-Alexis, On 04/03/2026 10:35, Louis-Alexis Eyraud wrote:quoted
From: AngeloGioacchino Del Regno [off-list ref] Add a new binding to support the Airoha AN8801R Series Gigabit Ethernet PHY. Signed-off-by: AngeloGioacchino Del Regno [off-list ref] Signed-off-by: Louis-Alexis Eyraud [off-list ref] --- .../devicetree/bindings/net/airoha,an8801.yaml | 81 ++++++++++++++++++++++ 1 file changed, 81 insertions(+) diff --git a/Documentation/devicetree/bindings/net/airoha,an8801.yaml b/Documentation/devicetree/bindings/net/airoha,an8801.yaml new file mode 100644 index 0000000000000000000000000000000000000000..f251c9d2fbbed3675c9fd7ff2 2174049a13a7b5e--- /dev/null +++ b/Documentation/devicetree/bindings/net/airoha,an8801.yaml@@ -0,0 +1,81 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/airoha,an8801.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Airoha AN8801R Series PHY + +maintainers: + - AngeloGioacchino Del Regno[off-list ref] + +description: + The Airoha AN8801R is a low power single-port Ethernet PHY Transceiver + with Single-port serdes interface for 1000Base-X/RGMII; this chip is + compliant with 10Base-T, 100Base-TX and 1000Base-T IEEE 802.3(u,ab) + and supports Energy Efficient Ethernet (802.3az), Full Duplex Control + Flow (802.3x), auto-negotiation, crossover detect and autocorrection, + Wake-on-LAN with Magic Packet, and Jumbo Frame up to 9 Kilobytes. + This PHY also supports up to three user-configurable LEDs, which are + usually used for LAN Activity, 100M, 1000M indication. + +allOf: + - $ref: ethernet-phy.yaml# + +properties: + compatible: + enum: + - ethernet-phy-idc0ff.0421 + + reg: + maxItems: 1 + + leds: true + +required: + - reg + - ledsSeems odd to me that leds are required. Any reason for that ? Maxime
I agree having the leds as required property is unneeded. I'll change it in v2. Regards, Louis-Alexis