Re: [PATCH bpf-next v1 3/7] tcp_bpf: refactor recvmsg with read actor abstraction
From: bot+bpf-ci@kernel.org
Date: 2026-03-04 07:14:20
Also in:
bpf, linux-kselftest, lkml
quoted hunk ↗ jump to hunk
diff --git a/net/core/skmsg.c b/net/core/skmsg.c index 2e26174c9919..6a906bfe3aa4 100644 --- a/net/core/skmsg.c +++ b/net/core/skmsg.c
[ ... ]
quoted hunk ↗ jump to hunk
@@ -440,7 +442,8 @@ int __sk_msg_recvmsg(struct sock *sk, ... if (copy) - copy = copy_page_to_iter(page, sge->offset, copy, iter); + copy = actor(actor_arg, page, + sge->offset, copy);
The direct copy_page_to_iter() call is now replaced by the actor
callback here, but deeper in the same function the peek-path comment
still references copy_page_to_iter() by name:
net/core/skmsg.c:sk_msg_read_core() {
...
} else {
/* Lets not optimize peek case if copy_page_to_iter
* didn't copy the entire length lets just break.
*/
if (copy != sge->length)
goto out;
...
}
Should this comment say "the actor" instead of "copy_page_to_iter"
now that the copy operation is abstracted behind the callback? Once
the splice actor is added later in this series, the reference to
copy_page_to_iter will be inaccurate for that path.
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/22658462977