Re: [PATCH net-next v4] net: mana: Add MAC address to vPort logs and clarify error messages
From: Erni Sri Satya Vennela <hidden>
Date: 2026-03-02 17:27:37
Also in:
linux-hyperv, lkml
From: Erni Sri Satya Vennela <hidden>
Date: 2026-03-02 17:27:37
Also in:
linux-hyperv, lkml
I have reservations about the usefulness of including __func__ and __LINE__ in debug messages. In a nutshell, it requires the logs to be correlated (exactly?) with the source used to build the driver. And at that point I think other mechanism - e.g. dynamic trace points - are going to be useful if the debug message (without function and line information) is insufficient to pinpoint the problem. This is a general statement, rather than something specifically about this code. But nonetheless I'd advise against adding this information here.
Thankyou Jakub and Simon for the suggestions. I'll remove both in the next version.