Re: [PATCH net-next v4] net: pppoe: implement GRO/GSO support

From
Qingfang Deng <dqfext@gmail.com>
Date
2026-03-02 07:34:31
Also in
lkml
Reply to
Qingfang Deng, 2026-02-28
On Sat, Feb 28, 2026 at 11:23 AM Qingfang Deng [off-list ref] wrote:
+       /* ignore packets with padding or invalid length */
+       if (skb_gro_len(skb) != be16_to_cpu(phdr->length) + hlen)
Both Claude (Netdev AI Review) and Gemini said `hlen` should be
replaced with `sizeof(*phdr)`. Is that correct?
Thread (3 messages) 3 messages, 2 authors, last reply 2026-03-03
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help