Re: [PATCH 17/61] module: Prefer IS_ERR_OR_NULL over manual NULL check
From: Aaron Tomlin <atomlin@atomlin.com>
Date: 2026-03-10 14:45:43
Also in:
amd-gfx, bpf, ceph-devel, cocci, dm-devel, dri-devel, gfs2, intel-gfx, intel-wired-lan, kvm, linux-block, linux-bluetooth, linux-btrfs, linux-cifs, linux-clk, linux-ext4, linux-fsdevel, linux-gpio, linux-hyperv, linux-input, linux-iommu, linux-leds, linux-media, linux-mips, linux-mm, linux-modules, linux-nfs, linux-omap, linux-phy, linux-pm, linux-rockchip, linux-s390, linux-scsi, linux-sctp, linux-security-module, linux-sh, linux-sound, linux-trace-kernel, linux-usb, linux-wireless, lkml, ntfs3, sched-ext, target-devel, v9fs
On Tue, Mar 10, 2026 at 12:48:43PM +0100, Philipp Hahn wrote:
quoted hunk ↗ jump to hunk
Prefer using IS_ERR_OR_NULL() over using IS_ERR() and a manual NULL check. Change generated with coccinelle. To: Luis Chamberlain <mcgrof@kernel.org> To: Petr Pavlu <petr.pavlu@suse.com> To: Daniel Gomez <da.gomez@kernel.org> To: Sami Tolvanen <samitolvanen@google.com> To: Aaron Tomlin <atomlin@atomlin.com> Cc: linux-modules@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Philipp Hahn <redacted> --- kernel/module/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/kernel/module/main.c b/kernel/module/main.c index c3ce106c70af165e2dc1a3c79f5a074a5c3e3d34..7f62f0620dcd75960e431f7af3d1cadf4cc41e4b 100644 --- a/kernel/module/main.c +++ b/kernel/module/main.c@@ -1551,7 +1551,7 @@ static int simplify_symbols(struct module *mod, const struct load_info *info) case SHN_UNDEF: ksym = resolve_symbol_wait(mod, info, name); /* Ok if resolved. */ - if (ksym && !IS_ERR(ksym)) { + if (!IS_ERR_OR_NULL(ksym)) { sym[i].st_value = kernel_symbol_value(ksym); break; }-- 2.43.0
Hi Philipp, Thank you. Have you considered other users of IS_ERR() in kernel/module/main.c too? Perhaps it might be best to prepare a clean up for each applicable subsystem in isolation. Kind regards, -- Aaron Tomlin
Attachments
- signature.asc [application/pgp-signature] 833 bytes