Re: [PATCH v2 000/110] vfs: change inode->i_ino from unsigned long to u64
From: NeilBrown <hidden>
Date: 2026-03-04 06:27:56
Also in:
amd-gfx, autofs, bpf, ceph-devel, dri-devel, linux-bluetooth, linux-can, linux-cifs, linux-ext4, linux-f2fs-devel, linux-fscrypt, linux-fsdevel, linux-hams, linux-integrity, linux-media, linux-mm, linux-nfs, linux-perf-users, linux-sctp, linux-security-module, linux-trace-kernel, linux-unionfs, linux-xfs, lkml, netfs, ntfs3, nvdimm, ocfs2-devel, selinux, v9fs
On Tue, 03 Mar 2026, Jeff Layton wrote:
On Tue, 2026-03-03 at 10:55 +0000, David Howells wrote:quoted
Jeff Layton [off-list ref] wrote:quoted
This version splits the change up to be more bisectable. It first adds a new kino_t typedef and a new "PRIino" macro to hold the width specifier for format strings. The conversion is done, and then everything is changed to remove the new macro and typedef.Why remove the typedef? It might be better to keep it.Why? After this change, internel kernel inodes will be u64's -- full stop. I don't see what the macro or typedef will buy us at that point.
Implicit documentation? ktime_t is (now) always s64, but we still keep the typedef; It would be cool if we could teach vsprintf to understand some new specifier to mean "kinode_t" or "ktime_t" etc. But that would trigger gcc warnings. NeilBrown