Re: [PATCH net] net: bcmasp: fix double frees during remove

On Thu, Mar 12, 2026 at 01:08:14PM -0700, justin.chen@broadcom.com wrote:

From: Justin Chen <justin.chen@broadcom.com>

We have two double frees during remove.
- We do not need to free wol_irq since it was instantiated with
  devm_request_irq(). So devres will free for us.

Hi Justin,

The above seems clear enough.

- Switch to devm_clk_get_optional() instead of
  devm_clk_get_optional_enabled() so we can manage the clock ourselves.

But it is unclear to me what problem this is solving.
Or how it relates to the first point - usually the aim
is to have one fix per patch.

Could you elaborate?

Fixes: a2f0751206b0 ("net: bcmasp: Add support for WoL magic packet")
Fixes: 490cb412007d ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
Signed-off-by: Justin Chen <justin.chen@broadcom.com>