Re: [PATCH net-next 5/8] phy: qcom-sgmii-eth: use PHY interface mode for SerDes settings
From: Vinod Koul <vkoul@kernel.org>
Date: 2026-02-27 13:43:53
Also in:
linux-arm-kernel, linux-arm-msm, linux-phy
On 25-02-26, 10:59, Russell King (Oracle) wrote:
As established in the previous commit, using SPEED_1000 and SPEED_2500 does not make sense for a SerDes due to the PCS encoding that is used over the SerDes link, which inflates the data rate at the SerDes. Thus, the use of these constants in a SerDes driver is incorrect. Since qcom-sgmii-eth no longer implements phy_set_speed(), but instead uses the PHY interface mode passed via the .set_mode() method, convert the driver to use the PHY interface mode internally to decide whether to configure the SerDes for 1.25Gbps or 3.125Gbps mode.
Acked-by: Vinod Koul <vkoul@kernel.org> -- ~Vinod