Re: [PATCH net-next 08/10] net: stmmac: qcom-ethqos: use phy interface mode for inband
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-02-25 01:10:54
Also in:
imx, linux-arm-kernel, linux-arm-msm
On Mon, 23 Feb 2026 09:34:51 +0000 Russell King (Oracle) wrote:
switch (speed) {
case SPEED_2500:
- rgmii_setmask(ethqos, RGMII_CONFIG2_RGMII_CLK_SEL_CFG,
- RGMII_IO_MACRO_CONFIG2);
- ethqos_set_serdes_speed(ethqos, SPEED_2500);
- ethqos_pcs_set_inband(priv, false);
- break;
case SPEED_1000:
rgmii_setmask(ethqos, RGMII_CONFIG2_RGMII_CLK_SEL_CFG,
RGMII_IO_MACRO_CONFIG2);
- ethqos_set_serdes_speed(ethqos, SPEED_1000);
- ethqos_pcs_set_inband(priv, true);Not clear to me why rgmii_setmask() goes away in the 2.5G case? Just checking it's intentional..