Re: [PATCH RFC net-next+ 4/9] net: stmmac: qcom-ethqos: convert to use phy_set_mode_ext()
From: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
Date: 2026-02-23 09:44:40
Also in:
linux-arm-kernel, linux-arm-msm, linux-phy
Hi Russell, On Thu, Feb 19, 2026 at 12:50:44PM +0000, Russell King (Oracle) wrote:
quoted hunk ↗ jump to hunk
@@ -675,20 +676,16 @@ static int ethqos_mac_finish_serdes(struct net_device *ndev, void *priv, phy_interface_t interface) { struct qcom_ethqos *ethqos = priv; - int speed, ret = 0; + int ret = 0; qcom_ethqos_set_sgmii_loopback(ethqos, false); - speed = SPEED_UNKNOWN; - if (interface == PHY_INTERFACE_MODE_SGMII) - speed = SPEED_1000; - else if (interface == PHY_INTERFACE_MODE_2500BASEX) - speed = SPEED_2500; - - if (speed != SPEED_UNKNOWN && speed != ethqos->serdes_speed) { - ret = phy_set_speed(ethqos->serdes_phy, speed); + if (interface == PHY_INTERFACE_MODE_SGMII || + interface == PHY_INTERFACE_MODE_2500BASEX) { + ret = phy_set_mode(ethqos->serdes_phy, PHY_MODE_ETHERNET, + interface);
Shouldn't this be phy_set_mode_ext()? Ayaan