Re: [PATCH RFC net-next 4/9] net: stmmac: qcom-ethqos: move qcom_ethqos_set_sgmii_loopback() up
From: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
Date: 2026-02-17 18:37:19
Also in:
imx, linux-arm-kernel, linux-arm-msm
On Thu, Feb 12, 2026 at 12:18:01AM +0000, Russell King (Oracle) wrote:
ethqos_set_func_clk_en() configures both SGMII loopback and the RGMII functional clock setting. qcom_ethqos_set_sgmii_loopback() is only called from within ethqos_set_func_clk_en(), and checks for PHY_INTERFACE_MODE_2500BASEX. Move qcom_ethqos_set_sgmii_loopback() to the callers of ethqos_set_func_clk_en() except for ethqos_configure_rgmii() where we know that ethqos->phy_mode will not be PHY_INTERFACE_MODE_2500BASEX. Signed-off-by: Russell King (Oracle) <redacted>
Reviewed-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com> Ayaan