Re: [PATCH bpf-next v2 1/5] netlink: specs: Add XDP RX checksum capability to XDP metadata specs
From: bot+bpf-ci@kernel.org
Date: 2026-02-13 16:00:04
Also in:
bpf, intel-wired-lan, linux-kselftest
Moreover, introduce xmo_rx_checksum netdev callback in order allow the eBPF program bounded to the device to retrieve the RX checksum result
This isn't a bug, but "in order allow" should be "in order to allow", and "bounded" should be "bound".
quoted hunk ↗ jump to hunk
diff --git a/net/core/xdp.c b/net/core/xdp.c --- a/net/core/xdp.c +++ b/net/core/xdp.c
[ ... ]
+/** + * bpf_xdp_metadata_rx_checksum - Read XDP frame RX checksum. + * @ctx: XDP context pointer. + * @ip_summed: Return value pointer indicating checksum result. + * @cksum_meta: Return value pointer indicating checksum result metadata. + * + * In case of success, ``ip_summed`` is set to the RX checksum result. Possible + * values are: + * ``XDP_CHECKSUM_NONE`` + * ``XDP_CHECKSUM_UNNECESSARY`` + * ``XDP_CHECKSUM_COMPLETE`` + * + * In case of success, ``cksum_meta`` contains the hw computed checksum value + * for ``XDP_CHECKSUM_COMPLETE`` or the ``csum_level`` for + * ``XDP_CHECKSUM_UNNECESSARY``. It is set to 0 for ``XDP_CHECKSUM_NONE`` + * + * Return: + * * Returns 0 on success or ``-errno`` on error. + * * ``-EOPNOTSUPP`` : means device driver does not implement kfunc + * * ``-ENODATA`` : means no RX-timestamp available for this frame
^^^^^^^^^^^^ Should this say "RX-checksum" instead of "RX-timestamp"? This looks like it was copied from bpf_xdp_metadata_rx_timestamp().
+ */
+__bpf_kfunc int bpf_xdp_metadata_rx_checksum(const struct xdp_md *ctx,
+ enum xdp_checksum *ip_summed,
+ u32 *cksum_meta)
+{
+ return -EOPNOTSUPP;
+}--- AI reviewed your patch. Please fix the bug or email reply why it's not a bug. See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md CI run summary: https://github.com/kernel-patches/bpf/actions/runs/21992879200 AI-authorship-score: low AI-authorship-explanation: Grammar mistakes and copy-paste error in kdoc are characteristic of human authorship by a non-native English speaker; Lorenzo Bianconi is an established kernel contributor. issues-found: 2 issue-severity-score: low issue-severity-explanation: Both issues are documentation errors: a copy-paste error in the kdoc (-ENODATA description says RX-timestamp instead of RX-checksum) and commit message grammar mistakes; neither affects runtime behavior.