Re: [PATCH net-next v2 6/6] net: sched: sch_dualpi2: use qdisc_dequeue_drop() for dequeue drops
From: kernel test robot <hidden>
Date: 2026-02-06 04:09:47
Also in:
bpf, llvm, oe-kbuild-all
Hi Jesper, kernel test robot noticed the following build errors: [auto build test ERROR on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Jesper-Dangaard-Brouer/net-sched-introduce-qdisc-specific-drop-reason-tracing/20260206-052816 base: net-next/main patch link: https://lore.kernel.org/r/177032652354.1975497.2269771162710918590.stgit%40firesoul patch subject: [PATCH net-next v2 6/6] net: sched: sch_dualpi2: use qdisc_dequeue_drop() for dequeue drops config: sparc64-randconfig-002-20260206 (https://download.01.org/0day-ci/archive/20260206/202602061240.CRDtcOeX-lkp@intel.com/config) compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260206/202602061240.CRDtcOeX-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot [off-list ref] | Closes: https://lore.kernel.org/oe-kbuild-all/202602061240.CRDtcOeX-lkp@intel.com/ (local) All errors (new ones prefixed by >>):
quoted
net/sched/sch_dualpi2.c:600:32: error: use of undeclared identifier 'QDISC_DROP_STEP_DROP'; did you mean 'QDISC_DROP_GENERIC'?
600 | drop_and_retry(q, skb, sch, QDISC_DROP_STEP_DROP);
| ^~~~~~~~~~~~~~~~~~~~
| QDISC_DROP_GENERIC
include/net/dropreason-qdisc.h:48:2: note: 'QDISC_DROP_GENERIC' declared here
48 | QDISC_DROP_GENERIC,
| ^
1 error generated.
vim +600 net/sched/sch_dualpi2.c
581
582 static struct sk_buff *dualpi2_qdisc_dequeue(struct Qdisc *sch)
583 {
584 struct dualpi2_sched_data *q = qdisc_priv(sch);
585 struct sk_buff *skb;
586 int credit_change;
587 u64 now;
588
589 now = ktime_get_ns();
590
591 while ((skb = dequeue_packet(sch, q, &credit_change, now))) {
592 if (!q->drop_early && must_drop(sch, q, skb)) {
593 drop_and_retry(q, skb, sch,
594 QDISC_DROP_CONGESTED);
595 continue;
596 }
597
598 if (skb_in_l_queue(skb) && do_step_aqm(q, skb, now)) {
599 qdisc_qstats_drop(q->l_queue);
> 600 drop_and_retry(q, skb, sch, QDISC_DROP_STEP_DROP);
601 continue;
602 }
603
604 q->c_protection_credit += credit_change;
605 qdisc_bstats_update(sch, skb);
606 break;
607 }
608
609 if (q->deferred_drops_cnt) {
610 qdisc_tree_reduce_backlog(sch, q->deferred_drops_cnt,
611 q->deferred_drops_len);
612 q->deferred_drops_cnt = 0;
613 q->deferred_drops_len = 0;
614 }
615 return skb;
616 }
617
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki