On 2026-02-01 09:19, Jakub Kicinski wrote:

On Thu, 29 Jan 2026 23:28:25 +0100 Daniel Borkmann wrote:

quoted

+	if (netif_running(dev))
+		netif_carrier_off(dev);
+	err = netif_set_real_num_rx_queues(dev, rxq_count_new);
+	if (netif_running(dev))
+		netif_carrier_on(dev);

Why do we need to flap the carrier?
(If there's a reason perhaps add a comment?)

I saw veth doing this in veth_set_channels(): off, set num rx queues,
then on. But it doesn't sound like there's actually a need? I'll test
without this and remove it if everything works.