Re: [PATCH] net: usb: kalmia: validate USB endpoints
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2026-02-25 14:34:40
Also in:
linux-usb, lkml
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2026-02-25 14:34:40
Also in:
linux-usb, lkml
On Tue, Feb 24, 2026 at 09:33:05AM +0000, Simon Horman wrote:
On Mon, Feb 23, 2026 at 01:59:26PM +0100, Greg Kroah-Hartman wrote:quoted
The kalmia driver should validate that the device it is probing has the proper number and types of USB endpoints it is expecting before it binds to it. If a malicious device were to not have the same urbs the driver will crash later on when it blindly accesses these endpoints. Cc: stable <stable@kernel.org> Assisted-by: gkh_clanker_2000 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>Hi Greg, As a fix I think this warrants a fixes tag. As this seems problem to go back to when this driver was added, perhaps this one: Fixes: d40261236e8e ("net/usb: Add Samsung Kalmia driver for Samsung GT-B3730") Regardless, this looks good to me. Reviewed-by: Simon Horman <horms@kernel.org> ...
Thanks for the review for this and the kaweth patch. And yes, I should have put a fixes tag there, but for stuff that's always been around, that's not really a big deal. greg k-h