Re: [PATCH net-next 1/7] bng_en: add per-PF workqueue, timer, and slow-path task
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-02-25 02:32:54
Also in:
lkml
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-02-25 02:32:54
Also in:
lkml
On Mon, 23 Feb 2026 22:06:35 +0530 Bhargava Marreddy wrote:
+ if (atomic_read(&bn->intr_sem) != 0) + goto bnge_restart_timer; + + /* Periodic work added by later patches */ + +bnge_restart_timer: + mod_timer(&bn->timer, jiffies + bn->current_interval);
This intr_sem thing looks highly questionable. It provides no synchronization guarantee since the state of intr_sem may change immediately after the read. Please use normal locking primitives and/or cancel the timer _sync() if you want to make sure it's not running.