Thread (5 messages) 5 messages, 3 authors, 2026-02-24

Re: [PATCH net-next] r8152: Add 2500baseT EEE status/configuration support

From: Birger Koblitz <hidden>
Date: 2026-02-24 17:33:03
Also in: linux-usb, lkml

Hi Daniel,

On 24/02/2026 2:33 am, Daniel Golle wrote:
quoted
  	tp->eee_en = eee->eee_enabled;
  	tp->eee_adv = val;
-
+	if (tp->support_2500full) {
+		val = linkmode_to_mii_eee_cap2_t(eee->advertised);
+		tp->eee_adv2 = val;
eee_adv2 set here is never actually written to the hardware.
ie. you are never doing
ocp_reg_write(tp, OCP_EEE_ADV2, tp->eee_adv2);
for capable NICs.
thanks for the feedback! You are of course right, the writing part was 
forgotten when editing the patch. I will send a corrected v2.

Birger
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help