Re: [PATCH net] net: mctp: usb: properly drop the usb interface on probe error
From: Jeremy Kerr <jk@codeconstruct.com.au>
Date: 2026-02-24 01:50:11
Also in:
lkml
Hi Greg, On a second look:
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/mctp/mctp-usb.c b/drivers/net/mctp/mctp-usb.c index ef860cfc629f..eef17ae89298 100644 --- a/drivers/net/mctp/mctp-usb.c +++ b/drivers/net/mctp/mctp-usb.c@@ -355,6 +355,7 @@ static int mctp_usb_probe(struct usb_interface *intf,usb_free_urb(dev->tx_urb); usb_free_urb(dev->rx_urb); free_netdev(netdev); + usb_put_dev(dev->usbdev); return rc; }
Should we not do the usb_put_dev() before the free_netdev()? Given we're in NETREG_UNINITIALIZED state, we're likely to be immediately freeing netdev there, which includes the netdev_priv data, ie., dev. Cheers, Jeremy