Re: [RFC net-next 0/4] ethtool: CMIS module diagnostic loopback support
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-02-23 23:04:03
Also in:
linux-rdma, lkml
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-02-23 23:04:03
Also in:
linux-rdma, lkml
On Sun, 22 Feb 2026 20:58:30 +0100 Björn Töpel wrote:
/* Loopback layers/scope
enum ethtool_loopback_layer {
ETHTOOL_LB_LAYER_SW = 0, /* Software/Kernel stack loopback */What would that be? :)
ETHTOOL_LB_LAYER_MAC, /* MAC/Controller internal */
ETHTOOL_LB_LAYER_PCS, /* Physical Coding Sublayer (Digital) */
ETHTOOL_LB_LAYER_PMA, /* SerDes / Analog-Digital boundary */
ETHTOOL_LB_LAYER_PMD, /* Transceiver / Module internal */In my mind the "layer" was supposed to tell core which driver to send the request to. Same concept is used in the timestamp source selection. PCS/PMA/PMD is both too fine grained when you have multiple PHYs in the path, and does not cover all the possible loopback points.
ETHTOOL_LB_LAYER_EXT, /* External physical plug/cable */
is EXT used somewhere to mean SFP already?