[PATCH 22/62] mctp i3c: Fix locking in error paths
From: Bart Van Assche <hidden>
Date: 2026-02-23 22:02:41
Also in:
lkml
Subsystem:
management component transport protocol (mctp), networking drivers, the rest · Maintainers:
Jeremy Kerr, Matt Johnston, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2026-02-23 · [PATCH 22/62] mctp i3c: Fix locking in error paths · Bart Van Assche <bvanassche@acm.org>
From: Bart Van Assche <bvanassche@acm.org>
Only unlock mi->lock if it has been locked. This bug has been detected by
the Clang thread-safety analyzer.
Cc: Leo Yang <redacted>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: Jeremy Kerr <jk@codeconstruct.com.au>
Cc: Matt Johnston <matt@codeconstruct.com.au>
Cc: netdev@vger.kernel.org
Fixes: 2d2d4f60ed26 ("mctp i3c: fix MCTP I3C driver multi-thread issue")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/net/mctp/mctp-i3c.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mctp/mctp-i3c.c b/drivers/net/mctp/mctp-i3c.c
index 6d2bbae7477b..d4a29912c7e1 100644
--- a/drivers/net/mctp/mctp-i3c.c
+++ b/drivers/net/mctp/mctp-i3c.c@@ -112,7 +112,7 @@ static int mctp_i3c_read(struct mctp_i3c_device *mi) if (!skb) { stats->rx_dropped++; rc = -ENOMEM; - goto err; + goto free_skb; } skb->protocol = htons(ETH_P_MCTP);
@@ -170,8 +170,11 @@ static int mctp_i3c_read(struct mctp_i3c_device *mi) mutex_unlock(&mi->lock); return 0; + err: mutex_unlock(&mi->lock); + +free_skb: kfree_skb(skb); return rc; }