Re: [PATCH net v1] net: defer __dev_set_promiscuity() to avoid sleeping in atomic context

From
Jakub Kicinski <kuba@kernel.org>
Date
2026-02-19 01:40:27
Also in
lkml
Reply to
Stanislav Fomichev, 2026-02-18
On Tue, 17 Feb 2026 17:10:36 -0800 Stanislav Fomichev wrote:
quoted
Reproducer:

  ip link add dummy0 type dummy
  ip link add team0 type team
  ip link set dummy0 master team0
  ip link set team0 up
  ip link add bridge0 type bridge vlan_filtering 1
  ip link set bridge0 up
  ip link set team0 master bridge0
  ip link add macsec0 link bridge0 type macsec
  ip link set macsec0 up   # triggers the bug  
Can you add it as a selftest under selftests/drivers/net/team/?
Stan, this "fix" may work for the promisc flag but won't we have 
the same problem with sync'ing the address list? Looks like team
will do:
 - team_set_rx_mode()
   - dev_uc_sync_multiple()
     - __dev_set_rx_mode(port->dev)
so AFAICT we're calling ndo_set_rx_mode without holding the instance
lock?
Thread (13 messages) 13 messages, 4 authors, last reply 2026-02-21
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help