-----Original Message-----
From: Paolo Abeni <pabeni@redhat.com>
Sent: Tuesday, February 10, 2026 7:06 AM
To: mike.marciniszyn@gmail.com; Alexander Duyck
[off-list ref]; Jakub Kicinski [off-list ref]; kernel-
team@meta.com; Andrew Lunn [off-list ref]; David S. Miller
[off-list ref]; Eric Dumazet [off-list ref]; Simon
Horman [off-list ref]; Russell King [off-list ref]; Keller,
Jacob E [off-list ref]; Mohsin Bashir
[off-list ref]; Lee Trager [off-list ref]; Dan Carpenter
[off-list ref]; Pei Xiao [off-list ref]; Stanislav
Fomichev [off-list ref]; Kuniyuki Iwashima [off-list ref];
Samiullah Khawaja [off-list ref]; Ahmed Zaki
[off-list ref]; Lobakin, Aleksander
[off-list ref]
Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v12 3/5] eth fbnic: Add msix self test

On 2/6/26 4:42 PM, mike.marciniszyn@gmail.com wrote:

quoted

+/**
+ * fbnic_msix_test - Verify behavior of NIC interrupts
+ * @fbd: device to test
+ *
+ * This function is meant to test the global interrupt registers and the
+ * PCIe IP MSI-X functionality. It essentially goes through and tests
+ * test various combinations of the set, clear, and mask bits in order to
+ * verify the behavior is as we expect it to be from the driver.
+ *
+ * Return: non-zero on failure.
+ **/
+int fbnic_msix_test(struct fbnic_dev *fbd)
+{
+	struct pci_dev *pdev = to_pci_dev(fbd->dev);
+	struct fbnic_msix_test_data *test_data;
+	int result = 0;
+	u32 mask = 0;
+	int i;
+
+	/* Allocate bitmap and IRQ vector table */
+	test_data = kzalloc(sizeof(*test_data), GFP_KERNEL);
+
+	/* Result = 5 for memory allocation failure */
+	if (!test_data)
+		return 5;

Instead of magic numbers you could define some macros, or simply return
a boolean success/failures value (as the caller ignores the error code).

/P

At least use -ENOMEM or something....