Re: [PATCH 00/19] printk cleanup - part 3
From: Marcos Paulo de Souza <hidden>
Date: 2026-02-20 11:43:57
Also in:
linux-arm-kernel, linux-fsdevel, linux-hardening, linux-m68k, linux-serial, linux-um, linuxppc-dev, lkml, sparclinux
On Sat, 2025-12-27 at 09:16 -0300, Marcos Paulo de Souza wrote:
The parts 1 and 2 can be found here [1] and here[2].
The changes proposed in this part 3 are mostly to clarify the usage
of
the interfaces for NBCON, and use the printk helpers more broadly.
Besides it, it also introduces a new way to register consoles
and drop thes the CON_ENABLED flag. It seems too much, but in reality
the changes are not complex, and as the title says, it's basically a
cleanup without changing the functional changes.
This patchset includes a patch from part 2 that needed more work [3],
as
suggested by Petr Mladek.
These changes were tested by reverting f79b163c4231
("Revert "serial: 8250: Switch to nbcon console""), and used qemu to
test
suspend/resume cycles, and everything worked as expected.
PS: b4 --auto-to-cc added a bunch of people as CC, so I'm not sure if
I should remove some or not, so I'm leaving the list as it is. If the
patchset needs a v2, and you feel that you don't need to copied, just
let me know.
Thanks for checking the patches, and happy holidays!
[1]:
https://lore.kernel.org/lkml/20250226-printk-renaming-v1-0-0b878577f2e6@suse.com/#t (local)
[2]:
https://lore.kernel.org/linux-serial/20251121-printk-cleanup-part2-v2-0-57b8b78647f4@suse.com/ (local)
[3]:
https://lore.kernel.org/linux-serial/aSgeqM3DWvR8-cMY@pathway.suse.cz/ (local)
Signed-off-by: Marcos Paulo de Souza <redacted>
---
Marcos Paulo de Souza (19):
printk/nbcon: Use an enum to specify the required callback in
console_is_usable()
printk: Introduce console_is_nbcon
printk: Drop flags argument from console_is_usable
printk: Reintroduce consoles_suspended global state
printk: Add more context to suspend/resume functions
printk: Introduce register_console_force
drivers: netconsole: Migrate to register_console_force helper
debug: debug_core: Migrate to register_console_force helper
m68k: emu: nfcon.c: Migrate to register_console_force helper
fs: pstore: platform: Migrate to register_console_force helper
powerpc: kernel: udbg: Migrate to register_console_force helper
sparc: kernel: btext: Migrate to register_console_force helper
um: drivers: mconsole_kern.c: Migrate to register_console_force
helper
drivers: hwtracing: stm: console.c: Migrate to
register_console_force helper
drivers: tty: serial: mux.c: Migrate to register_console_force
helper
drivers: tty: serial: ma35d1_serial: Migrate to
register_console_force helper
drivers: tty: ehv_bytechan: Migrate to register_console_force
helper
drivers: braille: console: Drop CON_ENABLED console flag
printk: Remove CON_ENABLED flag
arch/m68k/emu/nfcon.c | 5 +-
arch/powerpc/kernel/udbg.c | 4 +-
arch/sparc/kernel/btext.c | 4 +-
arch/um/drivers/mconsole_kern.c | 3 +-
arch/um/kernel/kmsg_dump.c | 2 +-
drivers/accessibility/braille/braille_console.c | 1 -
drivers/hwtracing/stm/console.c | 4 +-
drivers/net/netconsole.c | 13 +--
drivers/tty/ehv_bytechan.c | 4 +-
drivers/tty/serial/ma35d1_serial.c | 4 +-
drivers/tty/serial/mux.c | 4 +-
drivers/tty/tty_io.c | 6 +-
fs/proc/consoles.c | 1 -
fs/pstore/platform.c | 6 +-
include/linux/console.h | 143
+++++++++++++++++++-----
kernel/debug/debug_core.c | 6 +-
kernel/debug/kdb/kdb_io.c | 6 +-
kernel/printk/nbcon.c | 17 +--
kernel/printk/printk.c | 140 ++++++++++++--
---------
19 files changed, 230 insertions(+), 143 deletions(-)This patchset, without the recent cleanup from Petr Mladek [1], has a regression. I'll wait for it to be merged first before sending a new version of this patchset. Thanks for all the reviews! [1]: https://lore.kernel.org/lkml/20260206165002.496724-1-pmladek@suse.com/ (local)
--- base-commit: 93d65587479cfc97c0d7e41b5e8c6378ca681632 change-id: 20251202-printk-cleanup-part3-ea116b11b3a6 Best regards, -- Marcos Paulo de Souza [off-list ref]