Thread (1 message) 1 message, 1 author, 2026-02-07

Re: [PATCH net-next v14 1/4] dt-bindings: net: dsa: add MaxLinear MxL862xx

From: Vladimir Oltean <olteanv@gmail.com>
Date: 2026-02-07 21:48:45
Also in: linux-devicetree, lkml

On Sat, Feb 07, 2026 at 03:07:04AM +0000, Daniel Golle wrote:
RFC v4:
 * remove labels from example
 * remove 'bindings for' from commit title
...
+examples:
+  - |
+    mdio {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        switch@0 {
+            compatible = "maxlinear,mxl86282";
+            reg = <0>;
+
+            ethernet-ports {
+                #address-cells = <1>;
+                #size-cells = <0>;
+
+                port@9 {
+                    reg = <9>;
+                    label = "cpu";
Sorry, it's my fault really for not checking since v4 that you properly
applied my feedback to "Please remove port labels from the example."
https://lore.kernel.org/netdev/20251216224317.maxhcdsuqqxnywmu@skbuf/ (local)

There was an effort a few years ago to remove label = "cpu" at least
from dt-binding examples, if not from device trees as well, because the
"label" property is defined and parsed only for user ports, which the
CPU port is not. [ and even for user ports, it is discouraged except for
distributions with a sub-par udev implementation (OpenWrt) ].

This line should go away.
+                    ethernet = <&gmac0>;
+                    phy-mode = "usxgmii";
+
+                    fixed-link {
+                        speed = <10000>;
+                        full-duplex;
+                    };
+                };
+            };
+        };
+    };
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help