Re: [net-next,v2] bnge/bng_re: Add a new HSI
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-02-07 05:14:24
Also in:
linux-rdma, lkml
This is an AI-generated review of your patch. The human sending this email has considered the AI review valid, or at least plausible. For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html --- bnge/bng_re: Add a new HSI This commit adds a new HSI (Hardware Software Interface) for the BNGE and ThorUltra RoCE drivers. The HSI is automatically generated and shared between firmware and driver, replacing the existing BNXT HSI references.
quoted hunk ↗ jump to hunk
diff --git a/drivers/infiniband/hw/bng_re/bng_roce_hsi.h b/drivers/infiniband/hw/bng_re/bng_roce_hsi.h new file mode 100644 index 000000000000..1c4666eb0c87 --- /dev/null +++ b/drivers/infiniband/hw/bng_re/bng_roce_hsi.h@@ -0,0 +1,6450 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright (c) 2026 Broadcom */ + +/* DO NOT MODIFY!!! This file is automatically generated. */ + +#ifndef __BNG_RE_HSI_H__ +#define __BNG_RE_HSI_H__
[ ... ]
+}; + +#endif /* _ROCE_HSI_H_ */
^^^^^^^^^^^^^^^^ This isn't a bug, but the include guard comment doesn't match the actual macro name. The file opens with '__BNG_RE_HSI_H__' but closes with a comment referencing '_ROCE_HSI_H_'. The closing comment should read '/* __BNG_RE_HSI_H__ */' to match. While this doesn't affect compilation, it creates confusion for developers. Compare with the related include/linux/bnge/hsi.h which correctly uses matching guards throughout. -- pw-bot: cr