On Fri, 6 Feb 2026 03:30:30 +0000 Daniel Golle wrote:

quoted

quoted

+
+	/* provide additional space 'MXL862_HEADER_LEN' bytes */
+	skb_push(skb, MXL862_HEADER_LEN);  

[ ... ]
  

quoted

+	dsa_alloc_etype_header(skb, MXL862_HEADER_LEN);
+
+	/* special tag ingress */  

                      ^^^^^^^

This comment says "ingress" but mxl862_tag_xmit() is the TX/egress path.
Should this say "egress" instead?  

"ingress" is the perspective of the switch, and how the tag to be used
to send frames from the host to the switch is called in the datasheet[1]

Maybe expand on the comment a bit? Or remove it?
Cause reading the code I was also consued why this is called ingress