Re: [v4,net-next,02/11] net/nebula-matrix: add our driver architecture
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-02-07 02:24:51
Also in:
linux-doc, lkml
This is an AI-generated review of your patch. The human sending this email says "This is an automated AI code reviewer, please treat what it says with a grain of salt." For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html --- net/nebula-matrix: add our driver architecture This commit introduces the nebula-matrix network driver architecture, consisting of multiple layers: Device, Dispatch, Resource, Hardware, Channel, and Common. The architecture is designed for code reusability across multiple chip variants.
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c b/drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c --- a/drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c +++ b/drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c
[ ... ]
+static void nbl_get_func_param(struct pci_dev *pdev, kernel_ulong_t driver_data,
+ struct nbl_init_param *param)
+{[ ... ]
+ /* + * Leonis only PF0 has ctrl capability, but PF0's pcie device_id + * is same with other PF.So hanle it special.
^^^^^ This isn't a bug, but there's a typo: "hanle" should be "handle".
+ */