Thread (6 messages) 6 messages, 5 authors, 2026-02-04

Re: [PATCH phy] phy: enter drivers/phy/Makefile even without CONFIG_GENERIC_PHY

From: Venkat Rao Bagalkote <hidden>
Date: 2026-02-03 09:57:07
Also in: linux-phy, lkml

On 23/01/26 4:36 pm, Vladimir Oltean wrote:
quoted hunk ↗ jump to hunk
Kconfig option CONFIG_PHY_COMMON_PROPS, which builds
drivers/phy/phy-common-props.c, was intended to be selectable
independently of CONFIG_GENERIC_PHY. Yet it lives in drivers/phy/, which
is entered by the Makefile only if CONFIG_GENERIC_PHY is set.

Allow the Makefile to enter one level deeper, but stop at drivers/phy/
if CONFIG_GENERIC_PHY is unselected (i.e. do not enter vendor folders).
The other stuff from drivers/phy/Makefile except for CONFIG_PHY_COMMON_PROPS,
like CONFIG_PHY_NXP_PTN3222, all depends on CONFIG_GENERIC_PHY.

Fixes: e7556b59ba65 ("phy: add phy_get_rx_polarity() and phy_get_tx_polarity()")
Closes: https://lore.kernel.org/lkml/43ea0202-891d-4582-980b-5cb557b41114@linux.ibm.com/ (local)
Reported-by: Venkat Rao Bagalkote <redacted>
Debugged-by: "Christophe Leroy (CS GROUP)" [off-list ref]
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
  drivers/Makefile     | 2 +-
  drivers/phy/Makefile | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/Makefile b/drivers/Makefile
index ccc05f1eae3e..53fbd2e0acdd 100644
--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -10,7 +10,7 @@ obj-y				+= cache/
  obj-y				+= irqchip/
  obj-y				+= bus/
  
-obj-$(CONFIG_GENERIC_PHY)	+= phy/
+obj-y				+= phy/
  
  # GPIO must come after pinctrl as gpios may need to mux pins etc
  obj-$(CONFIG_PINCTRL)		+= pinctrl/
diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile
index 30b150d68de7..93715ea0d010 100644
--- a/drivers/phy/Makefile
+++ b/drivers/phy/Makefile
@@ -15,7 +15,7 @@ obj-$(CONFIG_PHY_SNPS_EUSB2)		+= phy-snps-eusb2.o
  obj-$(CONFIG_USB_LGM_PHY)		+= phy-lgm-usb.o
  obj-$(CONFIG_PHY_AIROHA_PCIE)		+= phy-airoha-pcie.o
  obj-$(CONFIG_PHY_NXP_PTN3222)		+= phy-nxp-ptn3222.o
-obj-y					+= allwinner/	\
+obj-$(CONFIG_GENERIC_PHY)		+= allwinner/	\
  					   amlogic/	\
  					   broadcom/	\
  					   cadence/	\

I still see linux-next build failures with next-20260202. Can we please 
have this patch merged.


Mark, can you please pull this one.


Regards,

Venkat.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help