Re: [PATCH v19 nf-next 1/5] net: pppoe: avoid zero-length arrays in struct pppoe_hdr
From: Florian Westphal <fw@strlen.de>
Date: 2026-02-24 14:15:52
Also in:
bridge, netfilter-devel
From: Florian Westphal <fw@strlen.de>
Date: 2026-02-24 14:15:52
Also in:
bridge, netfilter-devel
Eric Woudstra [off-list ref] wrote:
Jakub Kicinski suggested following patch: W=1 C=1 GCC build gives us: net/bridge/netfilter/nf_conntrack_bridge.c: note: in included file (through ../include/linux/if_pppox.h, ../include/uapi/linux/netfilter_bridge.h, ../include/linux/netfilter_bridge.h): include/uapi/linux/if_pppox.h: 153:29: warning: array of flexible structures It doesn't like that hdr has a zero-length array which overlaps proto. The kernel code doesn't currently need those arrays. PPPoE connection is functional after applying this patch.
LGTM, can you send this one directly to netdev@vger.kernel.org? Its not netfilter related so it feels wrong to apply it, even though I agree with it :-) No need to resend the rest of this series.