Re: [PATCH 18/62] bnxt_en: Fix bnxt_dl_reload_up()
From: Michael Chan <michael.chan@broadcom.com>
Date: 2026-02-23 23:43:07
Possibly related (same subject, not in this thread)
- 2026-02-23 · [PATCH 18/62] bnxt_en: Fix bnxt_dl_reload_up() · Bart Van Assche <hidden>
- 2026-02-23 · [PATCH 18/62] bnxt_en: Fix bnxt_dl_reload_up() · Bart Van Assche <bvanassche@acm.org>
On Mon, Feb 23, 2026 at 2:56 PM Bart Van Assche [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.cb/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c index 15de802bbac4..aa7ebd1426ed 100644--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c@@ -562,6 +562,13 @@ static int bnxt_dl_reload_up(struct devlink *dl,enum devlink_reload_action acti break; } default: + /* + * Other actions have already been rejected by + * bnxt_dl_reload_down(). + */ + WARN_ON_ONCE(true); + netdev_unlock(bp->dev); + rtnl_unlock();
This is better. It makes it clear that it should never get here.
return -EOPNOTSUPP;
}