Re: [PATCH net-next 1/9] psp: support rx rekey operation
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-02-07 04:24:19
Also in:
linux-kselftest
On Wed, 04 Feb 2026 07:20:05 -0800 Daniel Zahka wrote:
quoted hunk ↗ jump to hunk
--- a/include/net/psp/types.h +++ b/include/net/psp/types.h@@ -139,6 +139,9 @@ struct psp_assoc { u32 upgrade_seq; + struct psp_assoc *prev; + + bool tx_moved; struct psp_key_parsed tx; struct psp_key_parsed rx;
IIUC think tx_moved is going away in v2, but please double check the layout here with pahole -C psp_assoc. We the fastpath fields in the first cacheline (or two?) The tx_moved the way it's placed would create a hole, and hopefully for success path we don't have to check prev at all.