On Tue, Feb 3, 2026 9:56 PM, Andrew Lunn wrote:

quoted

 static void ngbe_reset(struct wx *wx)
 {
+	int err;
+
+	err = ngbe_reset_hw(wx);
+	if (err != 0)

The != 0 is a bit odd. It looks like rest of the driver uses if (err)

quoted

+		wx_err(wx, "Hardware Error: %d\n", err);

I also wounder if this should be fatal? Should ngbe_reset() be made an
int function so the error code can be returned?

The error returned by ngbe_reset_hw() indicates that there is a hardware
issue, and the recovery process will be handled in another work queue.
We hope that the driver can continue to complete the remaining software
reset.