Re: [PATCH] can: j1939: deactivate session upon receiving the second rts
From: Oleksij Rempel <o.rempel@pengutronix.de>
Date: 2026-01-14 10:17:54
Also in:
linux-can
On Wed, Jan 14, 2026 at 12:28:47AM +0900, Tetsuo Handa wrote:
Since j1939_session_deactivate_activate_next() in j1939_tp_rxtimer() is called only when the timer is enabled, we need to call j1939_session_deactivate_activate_next() if we cancelled the timer. Otherwise, refcount for j1939_session leaks, which will later appear as unregister_netdevice: waiting for vcan0 to become free. Usage count = 2. problem. Reported-by: syzbot <redacted> Closes: https://syzkaller.appspot.com/bug?extid=881d65229ca4f9ae8c84 Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Tested-by: Oleksij Rempel <o.rempel@pengutronix.de> Acked-by: Oleksij Rempel <o.rempel@pengutronix.de> Thank you! Best Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |