Thread (1 message) 1 message, 1 author, 2026-01-27

Re: [PATCH net-next v3] net: usb: remove unnecessary get_drvinfo code and driver versions

From: Peter Korsgaard <peter@korsgaard.com>
Date: 2026-01-27 07:43:24
Also in: linux-usb

quoted
quoted
quoted
quoted
"Ethan" == Ethan Nelson-Moore [off-list ref] writes:
 > Many USB network drivers define get_drvinfo functions which add no
 > value over usbnet_get_drvinfo, only setting the driver name and
 > version. usbnet_get_drvinfo automatically sets the driver name, and
 > separate driver versions are now frowned upon in the kernel. Remove all
 > driver versions and replace these get_drvinfo functions with references
 > to usbnet_get_drvinfo where possible. Where that is not possible,
 > remove unnecessary code to set the driver name. Also remove two
 > unnecessary initializations from aqc111_get_drvinfo, an inaccurate
 > comment in pegasus.c, and an unused macro in catc.c.

 > Reviewed-by: Andy Shevchenko [off-list ref]
 > Signed-off-by: Ethan Nelson-Moore [off-list ref]
 > ---
 > Changes in v3:
 > Add changelog
 > Add received Reviewed-by tag

 > Changes in v2:
 > Also remove driver versions from smsc[79]5xx (missed in the original
 > patch because they had a version definition but didn't use it in
 > get_drvinfo)

Reviewed-by: Peter Korsgaard <peter@korsgaard.com> (for dm9601.c)

-- 
Bye, Peter Korsgaard
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help