Re: [PATCH net-next v3] net: usb: remove unnecessary get_drvinfo code and driver versions
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2026-01-27 07:23:36
Also in:
linux-usb
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2026-01-27 07:23:36
Also in:
linux-usb
On Mon, Jan 26, 2026 at 10:04:38PM -0800, Ethan Nelson-Moore wrote:
Many USB network drivers define get_drvinfo functions which add no value over usbnet_get_drvinfo, only setting the driver name and version. usbnet_get_drvinfo automatically sets the driver name, and separate driver versions are now frowned upon in the kernel. Remove all driver versions and replace these get_drvinfo functions with references to usbnet_get_drvinfo where possible. Where that is not possible, remove unnecessary code to set the driver name. Also remove two unnecessary initializations from aqc111_get_drvinfo, an inaccurate comment in pegasus.c, and an unused macro in catc.c.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Ethan Nelson-Moore <redacted>
Andrew gave you a tag in v1 as well. Why is it not here? -- With Best Regards, Andy Shevchenko