On Thu, Jan 22, 2026 at 10:58:32PM -0800, Ethan Nelson-Moore wrote:

Several registers referenced in this driver's source code do not
actually exist (they are not writable and read as zero in my testing).
They exist in this driver because it originated as a copy of the dm9601
driver. Notably, these include the multicast filter registers - this
causes the driver to not support multicast packets correctly. Remove
the multicast filter code and instead set the chip to receive all
multicast filter packets when any multicast addresses are in the list.
Also take the opportunity to remove definitions for a few other
nonexistent registers, and a couple pointless comments.

Signed-off-by: Ethan Nelson-Moore <redacted>

I would slightly lean towards splitting this patch up,
say one for the multicast changes and removal of related #defines,
and another for the remainder of the #define clean-up.

But that notwithstanding this looks good to me.

Reviewed-by: Simon Horman <horms@kernel.org>