Re: [PATCH net-next] net: usb: dm9601: remove broken SR9700 support

quoted

quoted

quoted

quoted

"Ethan" == Ethan Nelson-Moore [off-list ref] writes:

 > The SR9700 chip sends more than one packet in a USB transaction,
 > like the DM962x chips can optionally do, but the dm9601 driver does not
 > support this mode, and the hardware does not have the DM962x
 > MODE_CTL register to disable it, so this driver drops packets on SR9700
 > devices. The sr9700 driver correctly handles receiving more than one
 > packet per transaction.

 > While the dm9601 driver could be improved to handle this, the easiest
 > way to fix this issue in the short term is to remove the SR9700 device
 > ID from the dm9601 driver so the sr9700 driver is always used. This
 > device ID should not have been in more than one driver to begin with.

 > The "Fixes" commit was chosen so that the patch is automatically
 > included in all kernels that have the sr9700 driver, even though the
 > issue affects dm9601.

 > Fixes: c9b37458e956 ("USB2NET : SR9700 : One chip USB 1.1 USB2NET
 > SR9700Device Driver Support")
 > Signed-off-by: Ethan Nelson-Moore [off-list ref]

I do not have access to a SR9700 device (and haven't touched anything
dm9601 related for a long time), but the above sounds sensible, so:

Acked-by: Peter Korsgaard <peter@korsgaard.com>

-- 
Bye, Peter Korsgaard