Thread (17 messages) 17 messages, 3 authors, 2026-01-08

Re: [PATCH net-next 4/9] net: stmmac: descs: fix buffer 1 off-by-one error

From: Maxime Chevallier <maxime.chevallier@bootlin.com>
Date: 2026-01-07 09:28:47
Also in: linux-arm-kernel

Hi Russell,

On 06/01/2026 21:31, Russell King (Oracle) wrote:
norm_set_tx_desc_len_on_ring() incorrectly tests the buffer length,
leading to a length of 2048 being squeezed into a bitfield covering
bits 10:0 - which results in the buffer 1 size being zero.

If this field is zero, buffer 1 is ignored, and thus is equivalent
to transmitting a zero length buffer.

Signed-off-by: Russell King (Oracle) <redacted>
Should it be a fix ? I've tried to trigger the bug without success, this
seems to be fairly specific so I'm OK with it going to net-next.

Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

Maxime
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help