[PATCH net-next v1 00/13] tools: ynl: clean up pylint issues
From: Donald Hunter <donald.hunter@gmail.com>
Date: 2026-01-07 12:22:03
Also in:
linux-doc
pylint tools/net/ynl/pyynl reports >850 issues, with a rating of 8.59/10. It's hard to spot new issues or genuine code smells in all that noise. Fix the easily fixable issues and suppress the noisy warnings. pylint tools/net/ynl/pyynl ************* Module pyynl.ethtool tools/net/ynl/pyynl/ethtool.py:159:5: W0511: TODO: --show-tunnels tunnel-info-get (fixme) tools/net/ynl/pyynl/ethtool.py:160:5: W0511: TODO: --show-module module-get (fixme) tools/net/ynl/pyynl/ethtool.py:161:5: W0511: TODO: --get-plca-cfg plca-get (fixme) tools/net/ynl/pyynl/ethtool.py:162:5: W0511: TODO: --get-plca-status plca-get-status (fixme) tools/net/ynl/pyynl/ethtool.py:163:5: W0511: TODO: --show-mm mm-get (fixme) tools/net/ynl/pyynl/ethtool.py:164:5: W0511: TODO: --show-fec fec-get (fixme) tools/net/ynl/pyynl/ethtool.py:165:5: W0511: TODO: --dump-module-eerpom module-eeprom-get (fixme) tools/net/ynl/pyynl/ethtool.py:166:5: W0511: TODO: pse-get (fixme) tools/net/ynl/pyynl/ethtool.py:167:5: W0511: TODO: rss-get (fixme) tools/net/ynl/pyynl/ethtool.py:179:9: W0511: TODO: parse the bitmask (fixme) tools/net/ynl/pyynl/ethtool.py:196:9: W0511: TODO: parse the bitmask (fixme) tools/net/ynl/pyynl/ethtool.py:321:9: W0511: TODO: pass id? (fixme) tools/net/ynl/pyynl/ethtool.py:330:17: W0511: TODO: support passing the bitmask (fixme) tools/net/ynl/pyynl/ethtool.py:459:5: W0511: TODO: wol-get (fixme) ------------------------------------------------------------------ Your code has been rated at 9.97/10 (previous run: 8.59/10, +1.38) Donald Hunter (13): tools: ynl: pylint suppressions and docstrings tools: ynl: fix pylint redefinition, encoding errors tools: ynl: fix pylint exception warnings tools: ynl: fix pylint dict, indentation, long lines, uninitialised tools: ynl: fix pylint misc warnings tools: ynl: fix pylint global variable related warnings tools: ynl: fix logic errors reported by pylint tools: ynl: ethtool: fix pylint issues tools: ynl: fix pylint issues in ynl_gen_rst tools: ynl-gen-c: suppress unhelpful pylint messages tools: ynl-gen-c: fix pylint warnings for returns, unused, redefined tools: ynl-gen-c: fix pylint None, type, dict, generators, init tools: ynl-gen-c: Fix remaining pylint warnings tools/net/ynl/pyynl/cli.py | 67 +++++--- tools/net/ynl/pyynl/ethtool.py | 47 +++-- tools/net/ynl/pyynl/lib/__init__.py | 10 +- tools/net/ynl/pyynl/lib/doc_generator.py | 3 +- tools/net/ynl/pyynl/lib/nlspec.py | 77 +++++---- tools/net/ynl/pyynl/lib/ynl.py | 208 +++++++++++++---------- tools/net/ynl/pyynl/ynl_gen_c.py | 175 ++++++++++--------- tools/net/ynl/pyynl/ynl_gen_rst.py | 2 + 8 files changed, 341 insertions(+), 248 deletions(-) -- 2.52.0