Re: [PATCH net-next v2 01/14] net: stmmac: qcom-ethqos: remove mac_base
From: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
Date: 2026-01-27 12:06:23
Also in:
linux-arm-kernel, linux-arm-msm, linux-phy
On Fri, Jan 23, 2026 at 09:53:23AM +0000, Russell King (Oracle) wrote:
quoted hunk ↗ jump to hunk
In commit 9b443e58a896 ("net: stmmac: qcom-ethqos: remove MAC_CTRL_REG modification"), ethqos->mac_base is only written, never read. Let's remove it. Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Russell King (Oracle) <redacted> --- drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 3 --- 1 file changed, 3 deletions(-)diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index 0826a7bd32ff..869f924f3cde 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c@@ -100,7 +100,6 @@ struct ethqos_emac_driver_data { struct qcom_ethqos { struct platform_device *pdev; void __iomem *rgmii_base; - void __iomem *mac_base; int (*configure_func)(struct qcom_ethqos *ethqos, int speed); unsigned int link_clk_rate;@@ -772,8 +771,6 @@ static int qcom_ethqos_probe(struct platform_device *pdev) return dev_err_probe(dev, PTR_ERR(ethqos->rgmii_base), "Failed to map rgmii resource\n"); - ethqos->mac_base = stmmac_res.addr; - data = of_device_get_match_data(dev); ethqos->por = data->por; ethqos->num_por = data->num_por;-- 2.47.3
Validated this patch on the QCS9100 Ride R3 board, so: Tested-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>