On Wed, Jan 14, 2026 at 06:55:34PM +0000, Russell King (Oracle) wrote:

On Wed, Jan 14, 2026 at 08:47:05PM +0200, Vladimir Oltean wrote:

quoted

On Wed, Jan 14, 2026 at 05:45:24PM +0000, Russell King (Oracle) wrote:

quoted

qcom-sgmii-eth is an Ethernet SerDes supporting only Ethernet mode
using SGMII, 1000BASE-X and 2500BASE-X.

Add an implementation of the .set_mode() method, which can be used
instead of or as well as the .set_speed() method. The Ethernet
interface modes mentioned above all have a fixed data rate, so
setting the mode is sufficient to fully specify the operating
parameters.

Add an implementation of the .validate() method, which will be
necessary to allow discovery of the SerDes capabilities for platform
independent SerDes support in the stmmac netowrk driver.

s/netowrk/network/

quoted

Signed-off-by: Russell King (Oracle) <redacted>
---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

According to patchwork (I forgot the RFC tag on the patches) it needs
linux/phy.h included. Plesae let me know if you'd like me to retain
your r-b. Thanks.

Ah, ok, I thought that the SPEED_* macros are also phylib-specific like
PHY_INTERFACE_MODE_*, and hence, the phylib header would already be included,
but it seems the SPEED_* macros are provided by include/uapi/linux/ethtool.h.
Go figure...

Please keep the review tag.