Re: [PATCH net v2] net: don't touch dev->stats in BPF redirect paths
From: patchwork-bot+netdevbpf@kernel.org
Date: 2026-01-31 21:20:13
Also in:
bpf
From: patchwork-bot+netdevbpf@kernel.org
Date: 2026-01-31 21:20:13
Also in:
bpf
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski [off-list ref]: On Thu, 29 Jan 2026 19:38:27 -0800 you wrote:
Gal reports that BPF redirect increments dev->stats.tx_errors on failure. This is not correct, most modern drivers completely ignore dev->stats so these drops will be invisible to the user. Core code should use the dedicated core stats which are folded into device stats in dev_get_stats(). Note that we're switching from tx_errors to tx_dropped. Core only has tx_dropped, hence presumably users already expect that counter to increment for "stack" Tx issues. [...]
Here is the summary with links:
- [net,v2] net: don't touch dev->stats in BPF redirect paths
https://git.kernel.org/netdev/net/c/fdf3f6800be3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html