RE: [Intel-wired-lan] [PATCH net-next 08/10] veth: Call skb_metadata_set when skb->data points past metadata

-----Original Message-----
From: Intel-wired-lan <redacted> On Behalf
Of Jakub Sitnicki via Intel-wired-lan
Sent: Saturday, January 10, 2026 10:05 PM
To: netdev@vger.kernel.org
Cc: David S. Miller <davem@davemloft.net>; Eric Dumazet
[off-list ref]; Jakub Kicinski [off-list ref]; Paolo Abeni
[off-list ref]; Simon Horman [off-list ref]; Michael Chan
[off-list ref]; Pavan Chebbi [off-list ref];
Andrew Lunn [off-list ref]; Nguyen, Anthony L
[off-list ref]; Kitszel, Przemyslaw
[off-list ref]; Saeed Mahameed [off-list ref];
Leon Romanovsky [off-list ref]; Tariq Toukan [off-list ref];
Mark Bloch [off-list ref]; Alexei Starovoitov [off-list ref];
Daniel Borkmann [off-list ref]; Jesper Dangaard Brouer
[off-list ref]; John Fastabend [off-list ref];
Stanislav Fomichev [off-list ref]; intel-wired-
lan@lists.osuosl.org; bpf@vger.kernel.org; kernel-team@cloudflare.com
Subject: [Intel-wired-lan] [PATCH net-next 08/10] veth: Call
skb_metadata_set when skb->data points past metadata

Prepare to copy the XDP metadata into an skb extension in
skb_metadata_set.

Unlike other drivers, veth calls skb_metadata_set after
eth_type_trans, which pulls the Ethernet header and moves skb->data.
This violates the new contract with skb_metadata.

Adjust the driver to pull the MAC header after calling
skb_metadata_set.

Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com>
---
 drivers/net/veth.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/veth.c b/drivers/net/veth.c index

14e6f2a2fb77..1d1dbfa2e5ef 100644

--- a/drivers/net/veth.c
+++ b/drivers/net/veth.c

@@ -874,11 +874,11 @@ static struct sk_buff *veth_xdp_rcv_skb(struct

veth_rq *rq,
 	else
 		skb->data_len = 0;

-	skb->protocol = eth_type_trans(skb, rq->dev);
-
 	metalen = xdp->data - xdp->data_meta;
 	if (metalen)
 		skb_metadata_set(skb, metalen);
+
+	skb->protocol = eth_type_trans(skb, rq->dev);
 out:
 	return skb;
 drop:

--
2.43.0