Re: [PATCH net-next v4 2/2] selftests: net: add ICMP error source address test over xfrm tunnel
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-01-30 02:43:19
Also in:
linux-kselftest, lkml
On Wed, 28 Jan 2026 11:20:45 +0100 Antony Antony wrote:
Test that ICMP error messages generated by an IPsec gateway use the correct source address (the gateway's address, not the unreachable destination).
could you check / fix shellcheck warnings?
+In xfrm_state.sh line 115:
+ $ksft_skip)
+ ^--------^ SC2254 (warning): Quote expansions in case patterns to match literally rather than as a glob.
+In xfrm_state.sh line 157:
+ [ -n "${NS_R1}" ] && ns_r1="ip netns exec ${NS_R1}" && ns_active="${ns_active} $NS_R1"
+ ^---^ SC2034 (warning): ns_r1 appears unused. Verify use (or export if used externally).
+
+
+In xfrm_state.sh line 162:
+ [ -n "${NS_B}" ] && ns_b="ip netns exec ${NS_B}" && ns_active="${ns_active} $NS_B"
+ ^--^ SC2034 (warning): ns_b appears unused. Verify use (or export if used externally).
+In xfrm_state.sh line 166:
+ local ns_cmd=$(nscmd $1)
+ ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values.
--
pw-bot: cr