Re: [PATCH net V2 2/4] net/mlx5: Fix deadlock between devlink lock and esw->wq
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-01-29 23:40:26
Also in:
linux-rdma, lkml
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-01-29 23:40:26
Also in:
linux-rdma, lkml
On Thu, 29 Jan 2026 10:33:40 +0000 Cosmin Ratiu wrote:
quoted
This is quite an ugly hack, is there no way to avoid the flush and let the work discover that what it was supposed to do is no longer needed?Not possible, unfortunately. I stared at it for quite a while. The wq is flushed because the esw is being unconfigured, which removes data structs the work handler uses. Flushing the work is required, otherwise we'll run into worse issues.
And having a refount on (I presume) struct mlx5_esw_functions so that work can hold a ref is not an option? Are you planning to revisit this in -next?