On Wed, Jan 28, 2026 at 5:01 PM Joe Damato [off-list ref] wrote:
On Wed, Jan 28, 2026 at 03:09:21PM -0800, Michael Chan wrote:
quoted
Alternatively, we can also change ethtool_get_flow_spec_ring_vf() to
check that the cookie is not RX_CLS_FLOW_DISC or RX_CLS_FLOW_WAKE.
That's up to the maintainers.
The existing drivers I checked which use ethtool_get_flow_spec_ring_vf all
explicitly check RX_CLS_FLOW_DISC, so it seems to be an established pattern.
I think we should fix this in the broadcom driver first and if there is a
desire from the maintainers to handle this in ethtool_get_flow_spec_ring_vf,
that can be done as a separate series which updates all of the drivers to
remove the redundant check.
Sounds good. Thanks.