Re: [PATCH net-next v4 1/8] net: dsa: microchip: Add support for KSZ8463 global irq
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-01-28 03:03:28
Also in:
lkml
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-01-28 03:03:28
Also in:
lkml
On Tue, 27 Jan 2026 10:06:43 +0100 Bastien Curutchet (Schneider Electric) wrote:
/* Read interrupt status register */ - ret = ksz_read8(dev, kirq->reg_status, &data); + ret = ksz_read16(dev, kirq->reg_status, &data);
AI code review points out that we're potentially over-reading here for !ksz_is_ksz8463(kirq->dev), I'm assuming the wider read is okay for all chips? Is this something that'll be obvious to all readers of this code or should we perhaps leave a relevant comment here? (assuming you need to respin, not sure its worth a respin by itself)