Re: [net-next,v5,05/13] octeontx2-af: npc: cn20k: Allocate default MCAM indexes
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-01-28 02:29:24
Also in:
lkml
This is an AI-generated review of your patch. The human sending this email has considered the AI review valid, or at least plausible. For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html --- octeontx2-af: npc: cn20k: Allocate default MCAM indexes This patch allocates MCAM indexes for promiscuous, multicast, broadcast, and unicast traffic when NIX LF is attached to PF/VF, improving allocation efficiency over the previous reservation method.
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/cn20k/npc.c b/drivers/net/ethernet/marvell/octeontx2/af/cn20k/npc.c index dd5352bd6dbf..6ae462d6ebaa 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/cn20k/npc.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/cn20k/npc.c
[ ... ]
+chk_sanity: + dev_dbg(rvu->dev, + "%s: Default index for pcifunc=%#x, bcast=%u mcast=%u promise=%u ucast=%u cnt=%u\n",
^^^^^^^ Should "promise" be "promisc" here? This appears to be a typo in the debug message. [ ... ]
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/cn20k/npc.h b/drivers/net/ethernet/marvell/octeontx2/af/cn20k/npc.h index aadee502bac1..f1734435db4d 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/cn20k/npc.h +++ b/drivers/net/ethernet/marvell/octeontx2/af/cn20k/npc.h
[ ... ]
+/** + * enum npc_dft_rule_id - Default rule type + * + * Mcam default rule type. + * + * @NPC_DFT_RULE_START_ID: Not used + * @NPC_DFT_RULE_PROMISC_ID: promiscuous rule + * @NPC_DFT_RULE_MCAST_ID: promiscuous rule
^^^^^^^^^^^^^^^^ Should this say "multicast rule" instead of "promiscuous rule"? It appears to be copied from the PROMISC line above.
+ * @NPC_DFT_RULE_BCAST_ID: broadcast rule + * @NPC_DFT_RULE_UCAST_ID: unicast rule + * @NPC_DFT_RULE_MAX_ID: Maximum index. + */
-- pw-bot: cr