On Tue, Jan 27, 2026 at 09:50:21AM +0800, Jijie Shao wrote:

on 2026/1/26 22:03, Simon Horman wrote:

quoted

On Fri, Jan 23, 2026 at 05:47:54PM +0800, Jijie Shao wrote:

quoted

The bit widths of HCLGE_FD_AD_QID and HCLGE_FD_AD_COUNTER_NUM are
increased to support higher specifications.

Note: The hardware already supports the specifications.

Hi Jijie,

Are there any compatibility issues here?
E.g. new driver with old hardware or firmware?

Thank you, There are no compatibility issues.

The chip and firmware are supported in V2.
However, the software does not support the extension due to
consistency with older versions(and the customer has not used the extended bits either).

The queue_cnt and counter_cnt specifications of the software are directly
or indirectly queried from the firmware, and the extended bits are not
used in the V1 version.

Thanks, I think that addresses my concern.

The code changes themselves look good to me.
So, for the series:

Reviewed-by: Simon Horman <horms@kernel.org>